[DTC] Resource and Datasource Implementation for DTC Monitor ICMP #274

Chaithra001 · 2025-11-25T04:22:48Z

No description provided.

docs/data-sources/dtc_monitor_icmp.md

docs/resources/dtc_monitor_icmp.md

docs/data-sources/dtc_monitor_icmp.md

Copilot

Pull request overview

This pull request implements a new resource and data source for DTC Monitor ICMP in the Terraform NIOS provider. The implementation follows the established patterns used for other DTC resources (LBDN, Server, Pool) in the codebase, providing full CRUD operations and comprehensive test coverage.

Key changes:

Adds nios_dtc_monitor_icmp resource with support for ICMP health monitoring configuration
Adds nios_dtc_monitor_icmp data source with filtering capabilities
Includes comprehensive test coverage for all resource attributes and data source filters

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
internal/service/dtc/model_dtc_monitor_icmp.go	Defines the data model, schema attributes, and Expand/Flatten methods for DTC Monitor ICMP
internal/service/dtc/dtc_monitor_icmp_resource.go	Implements CRUD operations for the DTC Monitor ICMP resource
internal/service/dtc/dtc_monitor_icmp_resource_test.go	Provides comprehensive acceptance tests for all resource attributes
internal/service/dtc/dtc_monitor_icmp_data_source.go	Implements the data source with filtering and paging support
internal/service/dtc/dtc_monitor_icmp_data_source_test.go	Tests data source filtering capabilities
internal/provider/provider.go	Registers the new resource and data source with the provider
examples/resources/nios_dtc_monitor_icmp/resource.tf	Provides usage examples for the resource
examples/data-sources/nios_dtc_monitor_icmp/data-source.tf	Provides usage examples for the data source
docs/resources/dtc_monitor_icmp.md	Generated documentation for the resource
docs/data-sources/dtc_monitor_icmp.md	Generated documentation for the data source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/service/dtc/model_dtc_monitor_icmp.go

docs/resources/dtc_monitor_icmp.md

docs/data-sources/dtc_monitor_icmp.md

internal/service/dtc/dtc_monitor_icmp_resource.go

docs/resources/dtc_monitor_icmp.md

docs/data-sources/dtc_monitor_icmp.md

docs/resources/dtc_monitor_icmp.md

…open#265) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/service/dtc/dtc_monitor_icmp_resource.go

docs/resources/dtc_monitor_icmp.md

internal/service/dtc/dtc_monitor_icmp_resource.go

Copilot · 2025-12-01T05:42:36Z

internal/service/dtc/dtc_monitor_icmp_resource.go

+	}
+	if associateInternalId != nil {
+		data.ExtAttrs, diags = AddInternalIDToExtAttrs(ctx, data.ExtAttrs, diags)
+		if diags.HasError() {


When diags.HasError() is true on line 262, the diagnostics are checked but never appended to resp.Diagnostics before returning. This means the error details won't be communicated to the user. Add resp.Diagnostics.Append(diags...) before the return statement on line 263.

Suggested change

if diags.HasError() {

if diags.HasError() {

resp.Diagnostics.Append(diags...)

Copilot · 2025-12-01T05:42:37Z

internal/service/dtc/model_dtc_monitor_icmp.go

+			customvalidator.ValidateTrimmedString(),
+			stringvalidator.LengthBetween(0, 256),


[nitpick] The order of validators should be consistent with similar DTC monitor resources. In model_dtc_monitor_snmp.go (lines 76-79), the stringvalidator.LengthBetween validator is placed before customvalidator.ValidateTrimmedString(). Consider reordering these validators to maintain consistency across the codebase.

Suggested change

customvalidator.ValidateTrimmedString(),

stringvalidator.LengthBetween(0, 256),

stringvalidator.LengthBetween(0, 256),

customvalidator.ValidateTrimmedString(),

Copilot · 2025-12-01T05:42:38Z

internal/service/dtc/dtc_monitor_icmp_resource.go

+
+	// Add internal ID exists in the Extensible Attributes if not already present
+	data.ExtAttrs, diags = AddInternalIDToExtAttrs(ctx, data.ExtAttrs, diags)
+	if diags.HasError() {


When diags.HasError() is true on line 77, the diagnostics are checked but never appended to resp.Diagnostics before returning. This means the error details won't be communicated to the user. Add resp.Diagnostics.Append(diags...) before the return statement on line 78.

Suggested change

if diags.HasError() {

if diags.HasError() {

resp.Diagnostics.Append(diags...)

Copilot · 2025-12-01T05:42:38Z

internal/service/dtc/model_dtc_monitor_icmp.go

+	"extattrs_all": schema.MapAttribute{
+		Computed:            true,
+		ElementType:         types.StringType,
+		MarkdownDescription: "Extensible attributes associated with the object , including default attributes.",


There is an extra space before the comma in "object , including". It should be "object, including".

Suggested change

MarkdownDescription: "Extensible attributes associated with the object , including default attributes.",

MarkdownDescription: "Extensible attributes associated with the object, including default attributes.",

Copilot · 2025-12-01T05:42:38Z

internal/service/dtc/dtc_monitor_icmp_resource.go

+	res := apiRes.CreateDtcMonitorIcmpResponseAsObject.GetResult()
+	res.ExtAttrs, data.ExtAttrsAll, diags = RemoveInheritedExtAttrs(ctx, data.ExtAttrs, *res.ExtAttrs)
+	if diags.HasError() {
+		resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", err))


The error message references err which is out of scope and will display an incorrect error. The err variable is from line 88 which checks the API call, but this error occurs when RemoveInheritedExtAttrs fails (line 94). The error message should reference diags instead: fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", diags)

Suggested change

resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", err))

resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", diags))

Copilot · 2025-12-01T05:42:39Z

internal/service/dtc/dtc_monitor_icmp_resource.go

+
+	res.ExtAttrs, data.ExtAttrsAll, diags = RemoveInheritedExtAttrs(ctx, data.ExtAttrs, *res.ExtAttrs)
+	if diags.HasError() {
+		resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while reading DtcMonitorIcmp due inherited Extensible attributes, got error: %s", diags))


The error message contains a grammatical error: "due inherited" should be "due to inherited". Corrected message: "Error while reading DtcMonitorIcmp due to inherited Extensible attributes"

Suggested change

resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while reading DtcMonitorIcmp due inherited Extensible attributes, got error: %s", diags))

resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while reading DtcMonitorIcmp due to inherited Extensible attributes, got error: %s", diags))

Chaithra001 added 5 commits November 17, 2025 14:10

added test cases for DTC monitor icmp

e6bc6d0

test case changes ICMP monitor

e155d07

Merge branch 'main' into DTC-Monitor-icmp

a913c12

minor changes

5b6cbdc

minor changes

6be1a09

Chaithra001 requested review from VishrutiBuddhadev and unasra November 25, 2025 04:23

minor changes

267c5df

unasra reviewed Nov 25, 2025

View reviewed changes

docs/data-sources/dtc_monitor_icmp.md Outdated Show resolved Hide resolved

docs/data-sources/dtc_monitor_icmp.md Outdated Show resolved Hide resolved

docs/resources/dtc_monitor_icmp.md Outdated Show resolved Hide resolved

docs/data-sources/dtc_monitor_icmp.md Outdated Show resolved Hide resolved

VishrutiBuddhadev changed the base branch from main to feature November 25, 2025 14:54

Chaithra001 added 2 commits November 26, 2025 15:26

addressing PR comments

522c17e

Merge branch 'feature' into DTC-Monitor-icmp

af84296

Chaithra001 requested a review from unasra November 26, 2025 09:59

unasra requested a review from Copilot November 27, 2025 08:11

Copilot started reviewing on behalf of unasra November 27, 2025 08:11 View session

Copilot finished reviewing on behalf of unasra November 27, 2025 08:14

Copilot AI reviewed Nov 27, 2025

View reviewed changes

Chaithra001 and others added 6 commits November 27, 2025 15:48

addressing PR review comments

a410137

Merge branch 'feature' into DTC-Monitor-icmp

5cb1b18

Merge branch 'feature' into DTC-Monitor-icmp

fe851db

Merge branch 'feature' into DTC-Monitor-icmp

1b325d6

minor changes

d21e928

unasra requested a review from Copilot December 1, 2025 05:31

Copilot started reviewing on behalf of unasra December 1, 2025 05:31 View session

Merge branch 'feature' into DTC-Monitor-icmp

6ca52c5

Copilot finished reviewing on behalf of unasra December 1, 2025 05:34

Copilot AI reviewed Dec 1, 2025

View reviewed changes

Chaithra001 added 2 commits December 1, 2025 15:32

addressing PR review comments

4c44e90

minor change

619f304

	if diags.HasError() {
	if diags.HasError() {
	resp.Diagnostics.Append(diags...)

		customvalidator.ValidateTrimmedString(),
		stringvalidator.LengthBetween(0, 256),

	MarkdownDescription: "Extensible attributes associated with the object , including default attributes.",
	MarkdownDescription: "Extensible attributes associated with the object, including default attributes.",

	resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", err))
	resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Error while create DtcMonitorIcmp due inherited Extensible attributes, got error: %s", diags))

[DTC] Resource and Datasource Implementation for DTC Monitor ICMP #274

Are you sure you want to change the base?

[DTC] Resource and Datasource Implementation for DTC Monitor ICMP #274

Uh oh!

Conversation

Chaithra001 commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants