Implement support for retrieving arbitrarily-large record sets with p… #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aging By default, the infoblox-ansible module will retrieve at most 1000 results, and silently discard the remainder. This can often be surprising and not what users intend. Trying to work around this limitation by setting large result-set sizes can also be resource intensive on both client and server. Our underpinning Python library natively supports the use of paging; it defaults to off, but is relatively trivial to wire up. This commit wires up a 'paging' boolean option in the infoblox provider, and defaults setting it to 'true'. It then passes this option to the underlying infoblox-client library. infobloxopen#293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aging
By default, the infoblox-ansible module will retrieve at most 1000 results, and silently discard the remainder. This can often be surprising and not what users intend. Trying to work around this limitation by setting large result-set sizes can also be resource intensive on both client and server.
Our underpinning Python library natively supports the use of paging; it defaults to off, but is relatively trivial to wire up.
This commit wires up a 'paging' boolean option in the infoblox provider, and defaults setting it to 'true'. It then passes this option to the underlying infoblox-client library.
#293