fix(common.adx): Make Close safe to call multiple times#18827
Open
skartikey wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix(common.adx): Make Close safe to call multiple times#18827skartikey wants to merge 1 commit intoinfluxdata:masterfrom
skartikey wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
Calling Close twice would dereference a nil client because the previous call sets adx.client = nil unconditionally. Guard the inner Close call and extend TestAlreadyClosed to actually invoke Close twice.
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
skartikey
added
the
ready for final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.Close()setsadx.client = nilafter closing, so a second call would dereference a nil client and panic. This guards the innerClose()call so the method is idempotent.TestAlreadyClosedis also extended to actually invokeClose()twice, which it didn't before despite its name.Checklist
Related issues
resolves #