fix(common.jolokia2): Add Jolokia 2.x compatibility for proxy target tag #18195
+204
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks so much for the pull request! |
Contributor
Author
|
!signed-cla |
Member
|
Thanks for the PR! The code looks good to me, but could you resolve the linter issues? Thanks! |
Jolokia 2.x changed the response format for proxy requests. The target URL is now returned under `request.options.target` instead of `request.target` (Jolokia 1.x format). This change adds support for both formats by checking both locations when extracting the target URL for the `jolokia_agent_url` tag. Without this fix, metrics from jolokia2_proxy plugin using Jolokia 2.x are missing the `jolokia_agent_url` tag, making it impossible to distinguish metrics from different proxy targets.
elohmeier
force-pushed
the
fix/jolokia2-proxy-target-tag
branch
from
cf49a86 to
90e4238
Compare
Contributor
Author
|
Thanks for the review @mstrandboge. Should be fixed now! |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jolokia 2.x changed the response format for proxy requests. The target URL is now returned under
request.options.targetinstead ofrequest.target(Jolokia 1.x format).This change adds support for both formats by checking both locations when extracting the target URL for the
jolokia_agent_urltag.Without this fix, metrics from
jolokia2_proxyplugin using Jolokia 2.x are missing thejolokia_agent_urltag, making it impossible to distinguish metrics from different proxy targets.Checklist
Related issues
resolves #18194