fix(inputs.nftables): Handle named counter references in JSON output #18177
+170
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
The nftables plugin failed to parse JSON output containing named counter
references. In nftables, counters can be either:
- Anonymous (inline objects): {"counter": {"packets": 100, "bytes": 5000}}
- Named references (strings): {"counter": "my_counter_name"}
The plugin only handled anonymous counters, causing a parse error:
"json: cannot unmarshal string into Go struct field"
Add custom UnmarshalJSON to the expr struct that detects and gracefully
skips named counter references, since they don't contain inline statistics.
Anonymous counters continue to be parsed and reported as before.
skartikey
force-pushed
the
inputs_nftables_named_counter
branch
from
d109235 to
d751f82
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The nftables plugin failed to parse JSON output containing named counter references. In nftables, counters can be either:
The plugin only handled anonymous counters, causing a parse error: "json: cannot unmarshal string into Go struct field"
Add custom UnmarshalJSON to the expr struct that detects and gracefully skips named counter references, since they don't contain inline statistics. Anonymous counters continue to be parsed and reported as before.
Checklist
Related issues
resolves #18135