Skip to content

build: pin pnpm version and add workspace config - #42

Open
maplepy wants to merge 1 commit into
infiniV:mainfrom
maplepy:fix/eslint-build
Open

build: pin pnpm version and add workspace config#42
maplepy wants to merge 1 commit into
infiniV:mainfrom
maplepy:fix/eslint-build

Conversation

@maplepy

@maplepy maplepy commented Jun 24, 2026

Copy link
Copy Markdown
  • Pin packageManager to pnpm@11.8.0 in package.json
  • Add pnpm-workspace.yaml to allow esbuild to resolve workspace dependencies
  • Regenerate lockfile

Fixes eslint build failure in CI — esbuild needs a pnpm workspace file to resolve packages.

Summary by CodeRabbit

  • Chores
    • Updated the project’s package manager metadata to standardize on a specific pnpm version.
    • Enabled an additional build allowance for the installation/setup process, which may improve compatibility for builds that rely on it.

- Set packageManager to pnpm@11.8.0 in package.json
- Add pnpm-workspace.yaml to allow esbuild builds
- Update pnpm-lock.yaml
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11f42e99-6eb1-4838-8e48-de1d6e1c4ed8

📥 Commits

Reviewing files that changed from the base of the PR and between f63609a and c107fab.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The workspace metadata now records pnpm 11.8.0, and the pnpm workspace config enables esbuild builds.

Changes

Workspace setup

Layer / File(s) Summary
Package manager and build config
package.json, pnpm-workspace.yaml
package.json records pnpm 11.8.0, and pnpm-workspace.yaml enables allowBuilds.esbuild.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hop by the workspace, quick and light,
pnpm’s named, and esbuild’s bright.
One tiny nibble, neat and clean,
A config patch in forest green.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main build changes: pinning pnpm and adding workspace configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maplepy

maplepy commented Jun 24, 2026

Copy link
Copy Markdown
Author

Sorry about the prefix, I just noticed the contributing guidelines! Tell me if you want it fixed to fix aha I can definitely do that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant