ID-107: check types of values returned from resolve_path#46
Open
ID-107: check types of values returned from resolve_path#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A recent update to the fhir navigation logic in inferno-core improved the ability of the resolve_path function. This resulted in some tests failing with purple errors due to unsafe use of the resolve_path function that didn't check the types of the returned values before accessing their properties. This update ensures that all uses of resolve_path are safe.
Testing Guidance
No explicit test failure was detected, so this is a preemptive fix. Run the test kit using the standard Reference Server preset to ensure no purple errors occur, with a focus on test 2.8.11 in the MedicationRequest group as that is the one that failed in US Core. You can use SAMPLE_TOKEN as the access token to avoid needing to run the smart tests.