Conversation
Shaumik-Ashraf
force-pushed
the
fi-3746-authinfo
branch
from
1cbac7c to
671bb86
Compare
Shaumik-Ashraf
changed the title
| default: nil, | ||
| locked: true, | ||
| optional: true | ||
| standalone_smart_auth_info: { |
There was a problem hiding this comment.
This should be smart_auth_info, none of this configuration is actually being applied.
| } | ||
| ] | ||
| "name": "smart_auth_info", | ||
| "title": "Backend Services Credentials", |
There was a problem hiding this comment.
This doesn't seem right.
| config( | ||
| inputs: { | ||
| smart_auth_info: { | ||
| name: :standalone_smart_auth_info |
There was a problem hiding this comment.
This also needs to be locked to public, and set to auth mode.
There was a problem hiding this comment.
This hasn't been done.
There was a problem hiding this comment.
this should now be fixed with the latest commit (833cd7b)
There was a problem hiding this comment.
I don't set auth mode at group level because this forces test 1.1 (SMART discovery) to get a client id and other auth mode inputs, which the current test kit does not require.
There was a problem hiding this comment.
It needs to be set to auth mode. They're going to need those inputs anyway to perform the launch, so I don't think it's a problem to have them in the discovery group too.
| group from: :<%= smart_launch_group_id %>, | ||
| config: { | ||
| inputs: { | ||
| standalone_smart_auth_info: { name: :smart_auth_info } |
2 participants
Summary
Testing Guidance
Run this test kit and comfirm identical behavior to main branch.