Skip to content

Gemspec and Ruby update#123

Open
FlexonyoPizza wants to merge 6 commits intoinferno-framework:masterfrom
FlexonyoPizza:master
Open

Gemspec and Ruby update#123
FlexonyoPizza wants to merge 6 commits intoinferno-framework:masterfrom
FlexonyoPizza:master

Conversation

@FlexonyoPizza
Copy link
Copy Markdown

Summary

  • Disabled 'AccessModifierDeclarations' cop in 'rubocop.yml'

  • RuboCop style autocorrections including:
    -RedundantParenthesis
    -ZeroLengthPredicate
    -HashEachMethods
    -MultipleComparison
    -RedundantRegexpEscape

Comment thread fhir_models.gemspec Outdated
Comment thread fhir_models.gemspec Outdated
@FlexonyoPizza FlexonyoPizza requested a review from karlnaden April 17, 2026 21:36
Comment thread fhir_models.gemspec
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'simplecov', '~> 0.17.0'
spec.add_development_dependency 'nokogiri-diff'
spec.add_development_dependency 'rubocop', '1.23.0'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete rubocop entirely here?

@FlexonyoPizza
Copy link
Copy Markdown
Author

In the future, we might consider parallel version 2.0 instead of 1.26 for both fhir_models and inferno-core? 1.26 supports ruby versions 2.7 and above. 2.0 supports ruby 3.3, which is the ruby version inferno-core uses right now.

@FlexonyoPizza FlexonyoPizza changed the title Addressing New RuboCop Offenses From Bundle Update Gemspec and Ruby update Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants