Add support for HTTP Basic Authentication by piotrekbator · Pull Request #33 · inf0rmer/blanket

piotrekbator · 2017-02-23T13:32:35Z

Complete with spec and Readme updates :)

houndci-bot · 2017-02-23T13:32:44Z

spec/blanket/wrapper_spec.rb

+        api = Blanket::wrap("http://api.example.org", basic_auth: basic_auth)
+        api.users(55).get
+
+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [111/80]

houndci-bot · 2017-02-23T13:32:44Z

spec/blanket/wrapper_spec.rb

+      end
+
+      it 'allows setting parameters globally' do
+        api = Blanket::wrap("http://api.example.org", basic_auth: basic_auth)


Do not use :: for method calls.

houndci-bot · 2017-02-23T13:32:45Z

spec/blanket/wrapper_spec.rb

+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)
+      end
+
+      it 'allows setting parameters globally' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-02-23T13:32:45Z

spec/blanket/wrapper_spec.rb

+      it 'allows sending parameters in a request' do
+        api.users(55).get(basic_auth: basic_auth)
+
+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [111/80]

houndci-bot · 2017-02-23T13:32:45Z

spec/blanket/wrapper_spec.rb

+        allow(HTTParty).to receive(:get) { StubbedResponse.new }
+      end
+
+      it 'allows sending parameters in a request' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-02-23T13:32:45Z

spec/blanket/wrapper_spec.rb

    end

+    describe 'Basic Auth' do
+      let(:basic_auth) { {username: 'foo', password: 'bar'} }


Space inside { missing.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Space inside } missing.

houndci-bot · 2017-02-23T13:32:45Z

spec/blanket/wrapper_spec.rb

      end
    end

+    describe 'Basic Auth' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

coveralls · 2017-02-23T13:34:06Z

Coverage decreased (-0.7%) to 98.208% when pulling e4684de on nibynic:master into 4f12b4a on inf0rmer:master.

coveralls · 2017-02-23T13:36:19Z

Coverage increased (+0.06%) to 98.929% when pulling aeed09e on nibynic:master into 4f12b4a on inf0rmer:master.

lazebny · 2017-04-22T10:04:08Z

Would be nice to have this feature in master.

houndci-bot · 2018-09-06T12:55:38Z

spec/blanket/wrapper_spec.rb

+        api = Blanket::wrap("http://api.example.org", basic_auth: basic_auth)
+        api.users(55).get
+
+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [111/80]

houndci-bot · 2018-09-06T12:55:38Z

spec/blanket/wrapper_spec.rb

+      end
+
+      it 'allows setting parameters globally' do
+        api = Blanket::wrap("http://api.example.org", basic_auth: basic_auth)


Style/ColonMethodCall: Do not use :: for method calls.

houndci-bot · 2018-09-06T12:55:38Z

spec/blanket/wrapper_spec.rb

+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)
+      end
+
+      it 'allows setting parameters globally' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-09-06T12:55:38Z

spec/blanket/wrapper_spec.rb

+      it 'allows sending parameters in a request' do
+        api.users(55).get(basic_auth: basic_auth)
+
+        expect(HTTParty).to have_received(:get).with('http://api.example.org/users/55', basic_auth: basic_auth)


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [111/80]

houndci-bot · 2018-09-06T12:55:39Z

spec/blanket/wrapper_spec.rb

+        allow(HTTParty).to receive(:get) { StubbedResponse.new }
+      end
+
+      it 'allows sending parameters in a request' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-09-06T12:55:39Z

spec/blanket/wrapper_spec.rb

    end

+    describe 'Basic Auth' do
+      let(:basic_auth) { {username: 'foo', password: 'bar'} }


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2018-09-06T12:55:39Z

spec/blanket/wrapper_spec.rb

      end
    end

+    describe 'Basic Auth' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

rpbaltazar · 2019-10-06T07:18:54Z

Why has this never made it to master? Is there any more up to date gem?

houndci-bot reviewed Feb 23, 2017

View reviewed changes

Adds support for HTTP Basic Authentication

aeed09e

piotrekbator force-pushed the master branch from e4684de to aeed09e Compare February 23, 2017 13:34

Support for passing general HTTP options to HTTParty

2d44787

houndci-bot reviewed Sep 6, 2018

View reviewed changes

Conversation

piotrekbator commented Feb 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Feb 23, 2017

Uh oh!

coveralls commented Feb 23, 2017

Uh oh!

lazebny commented Apr 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpbaltazar commented Oct 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

piotrekbator commented Feb 23, 2017 •

edited

Loading