-
Notifications
You must be signed in to change notification settings - Fork 15
Transition to arraycontext #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d74bfc1 to
5d95944
Compare
|
FYI I'm somewhere half-way resolving conflicts in this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I love that an explicit actx argument is necessary now. It might be better to have the actx globally in the toy context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very fine with that! Don't recall if I had any particular reason to make it explicit to each function (possibly to match P2P.__call__ and friends?).
|
Draft merge in #256. |
|
Continued in #256, closing here, since I can't seem to force-push here. |
Get
sumpyon array contexts as well! This eats up the first commit from #118.Porting individual files
test_codegentest_csetest_distributedtest_fmmtest_kernelstest_matrixgentest_misctest_qbxtest_toolscurve-potcurveexpansion-toysfouriersym-exp-complexityRemaining porting issues
KernelCacheMixin.get_cached_executor(), which branches onOPT_ENABLED, but we need to move toactx.call_loopy.transform_loopy_program? Would need to also add some fancy tags or something to customize it?register_optimization_preamblesto the array context somehow too.actx.transform_loopy_programsomehow?Upstream / downstream PRs
Speculative TODOs
actx? Here e.g.SumpyTreeIndependentDataForWranglerbut also inboxtree.actx.*Builderclasses can be functions + all other memoized kernels can be functions, but should leave that for later since it can be done without breaking the world.boxtree?