Skip to content

Add support for window can become key#12

Open
thibaut-jarosz wants to merge 3 commits into
indragiek:masterfrom
thibaut-jarosz:master
Open

Add support for window can become key#12
thibaut-jarosz wants to merge 3 commits into
indragiek:masterfrom
thibaut-jarosz:master

Conversation

@thibaut-jarosz
Copy link
Copy Markdown
Contributor

This allows popvover to be shown without main window resigning key.

@Arcnor
Copy link
Copy Markdown

Arcnor commented Jan 24, 2014

Is there a reason this hasn't been merged yet?

@dbrisinda
Copy link
Copy Markdown

dbrisinda commented Jan 18, 2017

It seems to me that this line is somewhat problematic as it requires additional setup:

if ( _windowCanBecomeKey )
    [positionWindow makeKeyAndOrderFront:nil];

I found another way for document-based apps that use many windows. For example, clicking another document window, which will close the popover, and allow the newly clicked document window to remain key:

if (positionWindow.mainWindow)
    [positionWindow makeKeyAndOrderFront:nil];

@indragiek indragiek force-pushed the master branch 2 times, most recently from 82c4c58 to ba272ac Compare December 26, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants