Improves support for the Pegasus PowerBox Micro (PPBM) when used with the indi_pegasus_ppba driver.#2339
Open
petercoxphoto wants to merge 1 commit intoindilib:masterfrom
Open
Conversation
- Detect device type (PPBA vs PPBM) from handshake response and record it in a new Firmware/Device Type field - Replace PI's single-toggle POWER_CHANNELS checkbox with an explicit On/Off button pair (QUAD_OUTPUT) in the Power tab, matching the style of other controls - Add a mirrored Quad Output On/Off control and live power sensors (Voltage/Current/Power) to the Main Control tab for quick access without switching tabs Tested against PPBM firmware 2.7.
petercoxphoto
changed the title
indi_pegasus_ppba driver.indi_pegasus_ppba driver.
Contributor
|
Thank you! Please do not delete any INDI::PowerInterface properties since these are supposed to form standard behavior for all Power devices. I suppose it might be possible to add another alias property but that would probably confuse the user more. |
Contributor
|
@petercoxphoto Any update? |
Contributor
I think you can keep the QUAD_OUTPUT but keep it synchronized with the single checkbox from PI::PowerInterface |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Handshake()now extracts the device model from the handshake response (PPBA_OK→PPBA,PPBM_OK→PPBM). The detected type is shown in a new "Device Type" row in the Firmware tab, and in the connection log message.POWER_CHANNELSsingle-toggle checkbox fromPI::PowerInterfaceis replaced by a two-button On / OffISR_1OFMANYswitch (QUAD_OUTPUT) in the Power tab — consistent with the LED control style and clearer to use.PI::PowerChannelsSPstate.Tested against PPBM firmware 2.7 connected via USB serial.