v3.3.3 - text reuse fixes and word embeddings UX improvement #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where text reuse search pills were missing labels. this is the case for Text reuse passages facets for clusters : it returns empty items (see related issue on IML impresso/impresso-middle-layer#648) The changes implement fallback handling for missing textReuseCluster data and batch loading of facets to improve performance. Key changes: Added batch facet loading via new loadFacets method to reduce API calls Implemented fallback label generation for textReuseCluster items without full data Improved null/undefined handling using isNaN checks instead of direct comparisons --------- Co-authored-by: Copilot <[email protected]>
* Refactor EmbeddingsSearch and improve filter integration Refactored EmbeddingsSearch.vue to use script setup, improved UI/UX, and enhanced filter management with preview and multi-word support. Updated FilterMonitor.vue and Search.vue to use the new EmbeddingsSearch API, including passing filters as props and handling filter changes via events. Replaced legacy modal with InfoModal in Search.vue and removed unused code. Replaced the Modal component with InfoModal in Search.vue and updated the embeddings search integration * Make InfoModal title optional and update prop name The modal title is now only rendered if provided, and the default prop name was changed from 'title' to 'modalTitle' for clarity. * Update style.css * Add buttonClass prop to Dropdown component Introduces a new 'buttonClass' prop to allow custom classes on the dropdown button. This provides greater flexibility for styling the Dropdown component. * Add Storybook stories and mock data for EmbeddingsSearch Introduces a mock data file for word embeddings and a Storybook story for the EmbeddingsSearch component. The story uses MSW to mock API responses, enabling isolated UI testing with sample data. Added error handling to TextReuse.vue for improved debugging --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1774 , #1784, #1843