Fix Particle file output spacing for consistency and ease of parsing#32
Merged
qianglbl merged 3 commits intoimpact-lbl:masterfrom Feb 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
conda-forge's compilersParticle file output
This fixes the leading spaces in output particle files. This saves a bit of space and makes it slightly easier for not-so-smart parsers to read the output particles (specifically
polars.read_csvon our end, which can be ~10x faster thannumpy.loadtxtfor large particle output files).Currently particles look like this:
After this PR, the leading space and double spaces between should be removed.
g0formatting looks like the following:Fortunately, there does not appear to be a trailing space inserted with
9(g0,1x).CI fix
makeworkflow to work with modern compilers wasn't being passed (-fallow-argument-mismatch)MPICHon GitHub Actions appears to have issues assigning the number of requested processors for the communicatorMPIR_Cart_create_impl(41): Size of the communicator (1) is smaller than the size of the Cartesian topology (2)(Similar to impact-lbl/IMPACT-Z#12)