feat(checkout): Add response validation schema and report if validation error #2683
Conversation
|
View your CI Pipeline Execution ↗ for commit 77e954f
☁️ Nx Cloud last updated this comment at |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "root": true, | |||
| "extends": [ | |||
There was a problem hiding this comment.
there was a conflicting jsx-ally rule being loaded from both these inherits so had to remove one. I tried adding the one from the root and remove next/ but it resulted in a lot of linting errors that need to be addressed on its own. Currently no lint is really applied as the package.json is linting only *.ts files inside src/ which is ignored by the ignorePatterns from the root eslint rule since it is missing root: true which is added above.
| if (params.nextPage) url += `&${new URLSearchParams(params.nextPage as Record<string, string>)}`; | ||
|
|
||
| // Use the generic httpGet method with schema validation | ||
| const response = await this.httpGet<BlockscoutERC20Response>(url, BlockscoutERC20ResponseSchema); |
There was a problem hiding this comment.
Do you need to pass the type parameter given you're passing the schema? The return type should be inferrable from that
|
|
||
| export const BlockscoutTokenPaginationSchema = z.record( | ||
| z.string(), | ||
| z.union([z.string(), z.number(), z.null()]), |
There was a problem hiding this comment.
why like this? and not declaring the specific keys?
| // Only validate response structure for successful responses (2xx) | ||
| if (response.status >= 200 && response.status < 300) { | ||
| try { | ||
| const validatedData = schema.parse(response.data); |
There was a problem hiding this comment.
slightly preferable would be to use safeParse to handle the error case- not a blocker though
| } | ||
|
|
||
| // For non-2xx responses, return data without validation | ||
| return Promise.resolve(response.data); |
There was a problem hiding this comment.
Doesn't seem quite right - if the response is 400, the return type should probably be unknown
Or it should reject... what does this.httpClient.get currently do if it gets a >= 300 response?
Further, use the error reporting to alert us of the change in fields so we can proactively figure it out.