Repository navigation
feat(mobile): add confirmation dialogs to delete action buttons - #25113
ByteSizedMarius wants to merge 4 commits into
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ByteSizedMarius You can rebase this branch on top of #25739 which adds the |
b86e854 to
d96e0dc
Compare
d96e0dc to
a5abd60
Compare
* feat: mobile ui showcase * remove showcase from main app * update fonts * update code to be loaded from asset * fix ci --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
a35eeb9 to
3a44561
Compare
|
@ByteSizedMarius You might have to rebase this again. But probably best to do it after the html PR is merged onto main |
a5abd60 to
4913569
Compare
I may be reading your mind, was already in the process of doing this. That's ok, I can update again when it's merged :) |
3a44561 to
81c6b96
Compare
|
Im guessing this was closed automatically with the base branch being merged? Please reopen @shenlong-tanwen |
|
@ByteSizedMarius Not sure what happened there, As the PR was fairly small, Can you just open a new PR with the changes? Apologies and Thanks for the contribution |
Description
Adds confirmation dialogs to
DeletePermanentActionButtonto prevent accidental deletion. Addresses #19775.When deleting photos/videos from grid view (multiselect), there's no confirmation dialog. This is particularly dangerous for locked folder content where deletion is permanent and irreversible. This is an opinionated change and open to discussion, but in my opinion, deletions (especially permanent, but also when sent to trash) should always have a confirmation.
Ref #25111
Changes
Add confirmation dialog to
DeletePermanentActionButton. Permanent deletions should always shows a confirmation, so there is no parameter to toggle it off.How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Claude Code was used to assist with implementation.