feat(server): sidecars in asset_files #21199
Draft
+309
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
24 times, most recently
from
7f6d51a to
323c707
Compare
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
from
323c707 to
cba9e29
Compare
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
4 times, most recently
from
6341602 to
12444be
Compare
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
from
12444be to
430af9a
Compare
…/immich into feat/sidecar-asset-files
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
from
a29516d to
6b91b31
Compare
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
5 times, most recently
from
80d8631 to
4fdfb9a
Compare
…/sidecar-asset-files
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
from
4fdfb9a to
11ea09c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move sidecar information from the asset table to the asset_files table, thereby saving one row in the asset table.
Beyond cleaning up, this will unlock further optimizations in the future. For instance, the slowest part external library scanning is currently...sidecar file detection. We'll be able to do a separate fast crawl for (the few) xmp files in an external library instead of the very slow probing for img.jpg.xmp and img.xmp for every img.jpg in the library.