Merged
Conversation
camdencove
approved these changes
Jan 20, 2026
Member
camdencove
left a comment
camdencove
left a comment
There was a problem hiding this comment.
Thanks so much for submitting this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses mixins to change how
SkullBlockRendererworks --- specifically, it would now detect if an image is the special IF format (with RGB (2,1,3) in a specific location), if so, it would extract the control bits and rescale the image to the proper size and render it.To obtain the texture identifier from
RenderType, it uses reflection to getRenderSetup$TextureBinding. The method namecomp_5228is an intermediary name for "location", which is the desired identifier.Note that some images are given in RGB format and uses (2,1,3) to represent the transparent background. To correctly render them, the mod reformats those images, registers them with
TextureManager, and uses them instead for rendering.TODO: decide the directory structure, at this moment the mixins is directly in net.imaginefun.mixins (without a client subbranch).