Calculate GCD in Ratio::new #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code itself looks good to me, but TBH I'm not really sure what the implications of this change are |
|
I think you can derive |
197g
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
I think I'm on board with the advantage of being able to rely on comparison, no matter the underlying granularity. The loop has at most 32 iterations as well so the effects on any existing code using that constructor should not be drastic. And in any case, I do not expect this to be used as part of a really tight loop anywhere. (We're already deriving Eq though which is .. odd).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I saw this comment and wrote this code on a whim. If it's completely unnecessary that's fine.