Skip to content

fix: prevent curve overshooting #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent curve overshooting #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/src/chart/line_chart/line_chart_painter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,12 @@ class LineChartPainter extends AxisChartPainter<LineChartData> {
getPixelY(barSpots[i + 1 < size ? i + 1 : i].y, viewSize, holder),
);

final controlPoint1 = previous + temp;
var controlPoint1 = previous + temp;

/// Prevent controlPoint1 overshooting in the x-axis
if (barData.preventCurveOverShooting && controlPoint1.dx > current.dx) {
controlPoint1 = Offset(current.dx, controlPoint1.dy);
}

/// if the isCurved is false, we set 0 for smoothness,
/// it means we should not have any smoothness then we face with
Expand All @@ -625,7 +630,12 @@ class LineChartPainter extends AxisChartPainter<LineChartData> {
}
}

final controlPoint2 = current - temp;
var controlPoint2 = current - temp;

/// Prevent controlPoint2 overshooting in the x-axis
if (barData.preventCurveOverShooting && controlPoint2.dx < previous.dx) {
controlPoint2 = Offset(previous.dx, controlPoint2.dy);
}

path.cubicTo(
controlPoint1.dx,
Expand Down