This repository was archived by the owner on Apr 20, 2020. It is now read-only.
Remove dead code code related to knime export#317
Open
k-dominik wants to merge 1 commit intoilastik:masterfrom
Open
Remove dead code code related to knime export#317k-dominik wants to merge 1 commit intoilastik:masterfrom
k-dominik wants to merge 1 commit intoilastik:masterfrom
Conversation
I'd propose to get rid of this code that does not seem to be used at all, or would you want to keep it in for reference? In any case, one of those files has to go, since they duplicate code ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while we are at it...
I don't think this code is used at all. Do you want to keep it for reference @akreshuk ? In any case I'd suggest to remove at least
lazyflow/operators/ioOperators/hdf5SerializerKnime.py