fix(ci): cargo command for rust workers + fetch annotated tag content#68
fix(ci): cargo command for rust workers + fetch annotated tag content#68
Conversation
- _publish-registry.yml: prefix the rust worker cargo_args expansion with `cargo` so the local interface-collection step actually invokes `cargo run`. Without this the runner tried to exec `run` as a program and exited with `run: command not found`, killing image-resize before the engine could read its functions. - release.yml: add `fetch-tags: true` to the setup checkout. fetch-depth=0 alone does not pull tag annotations, which made the `git tag -l --format=%(contents)` lookup return empty, defaulting registry-tag to `latest` even when the tag's message specified `next`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo independent GitHub Actions workflow updates: one fixes the Rust worker startup command to explicitly invoke ChangesRust Worker Invocation Clarification
Release Workflow Tag Fetching
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Summary
Two follow-up fixes uncovered by the first publish attempt after #67 merged (failing run):
_publish-registry.yml— the rust worker startup expandedcargo_args=(run ...)directly as the command, so the runner tried to execrunand died withrun: command not found. Prefix the expansion withcargoso it actually launchescargo run.release.yml—fetch-depth: 0does not bring annotated tag content. Thegit tag -l --format=%(contents)lookup returned empty, falling back toregistry-tag=latesteven when the create-tag dispatch wroteregistry-tag: nextinto the annotation. Addfetch-tags: trueto the setup checkout.Test plan
create-tag.ymlwithworker=image-resize, bump=patch, tag=nextSetupnotice printsregistry-tag=nextStart local worker for interface collectionrunscargo run --bin image-resize --and the worker stays alivetag: "next"in the payloadSummary by CodeRabbit
Release Notes
No user-facing changes in this release. This update includes internal workflow improvements to the CI/CD pipeline for better build and release automation.