-
Notifications
You must be signed in to change notification settings - Fork 1
feat(database): iii-database worker (sqlite/postgres/mysql) + e2e harness #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2c7554d
chore: ignore .worktrees
andersonleal 4395424
feat(database): introduce iii-database worker
andersonleal cf44e23
ci(database): vendor e2e harness + add database-e2e workflow
andersonleal 8918a6f
ci(database): harden run-tests.sh + workflow against transient flake
andersonleal 47da369
ci: register iii-database in create-tag + release workflows
andersonleal 1cbc8a1
ci(database): activate gated DB tests + fix over-specific mysql asser…
andersonleal e311da2
chore(database): drop unnecessary comments
andersonleal 5459ef5
chore(database): apply consistent formatting across code base
andersonleal dd2ff7e
rename folder
andersonleal a116a66
ci: catch CI references up to the database -> iii-database rename
andersonleal ba359be
refactor(database): register functions via typed RegisterFunction::ne…
andersonleal a2080aa
fix(database): wrap mysql query timeout around row streaming, not jus…
andersonleal f2cfa50
fix(database): decode TIMESTAMP (no tz) via NaiveDateTime, not DateTi…
andersonleal b163890
fix(database): decode postgres NUMERIC via rust_decimal, not String
andersonleal 31289d6
fix(database): route sqlite tx steps via column_count, not text matching
andersonleal 3200fe8
fix(database): six review findings (tx guards, signal handling, log r…
andersonleal 4f2dff3
fix(database): NUMERIC decode fallback + preserve tx step index in ro…
andersonleal 3739d89
test(database): integration coverage for NUMERIC binary-fallback path
andersonleal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ on: | |
| required: true | ||
| type: choice | ||
| options: | ||
| - iii-database | ||
| - iii-lsp | ||
| - iii-lsp-vscode | ||
| - image-resize | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| name: iii-database E2E | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'iii-database/**' | ||
| - '.github/workflows/iii-database-e2e.yml' | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: iii-database-e2e-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: | ||
| e2e: | ||
| name: Harness (sqlite + postgres + mysql) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 25 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Rewrite SSH to HTTPS for public deps | ||
| run: git config --global url."https://github.com/".insteadOf "ssh://git@github.com/" | ||
|
|
||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - name: Cache cargo registry & build | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: iii-database | ||
|
|
||
| - name: Install Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
| cache-dependency-path: iii-database/tests/e2e/workers/harness/package-lock.json | ||
|
|
||
| # GHA `services:` blocks can't pass `-c wal_level=logical` to postgres, | ||
| # which the row-change tests require. Reuse the same docker-compose | ||
| # stack the harness uses locally for dev/CI parity. | ||
| - name: Install iii engine (latest from main) | ||
| run: | | ||
| curl -fsSL --retry 3 --retry-connrefused --retry-delay 5 \ | ||
| https://install.iii.dev/iii/main/install.sh | sh | ||
| echo "$HOME/.local/bin" >> "$GITHUB_PATH" | ||
|
|
||
| - name: Verify engine | ||
| run: iii --version | ||
|
|
||
| - name: Run harness | ||
| working-directory: iii-database/tests/e2e | ||
| # --with-cargo-test runs `cargo test --all-features` against the | ||
| # already-running postgres + mysql so the gated driver/pool tests | ||
| # actually exercise their target DBs (otherwise they early-return). | ||
| run: ./run-tests.sh --with-cargo-test | ||
|
|
||
| - name: Upload report on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: iii-database-e2e-report | ||
| path: | | ||
| iii-database/tests/e2e/reports/ | ||
| retention-days: 7 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ name: Release | |
| on: | ||
| push: | ||
| tags: | ||
| - 'iii-database/v*' | ||
| - 'iii-lsp/v*' | ||
| - 'image-resize/v*' | ||
| - 'mcp/v*' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| target/ | ||
| *.db | ||
| *.sqlite | ||
| *.sqlite-journal | ||
| /data/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.