Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Sep 24, 2025

#392 ← previous PR | following PR → #447

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added this to the 2025-11 milestone Sep 24, 2025
@khaeru khaeru self-assigned this Sep 24, 2025
@khaeru khaeru added enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model labels Sep 24, 2025
@khaeru khaeru mentioned this pull request Sep 24, 2025
7 tasks
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.7%. Comparing base (5ec6ae5) to head (3eba191).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #430     +/-   ##
=======================================
- Coverage   75.3%   74.7%   -0.7%     
=======================================
  Files        272     274      +2     
  Lines      22463   22488     +25     
=======================================
- Hits       16932   16807    -125     
- Misses      5531    5681    +150     
Files with missing lines Coverage Δ
message_ix_models/model/snapshot.py 24.5% <100.0%> (-75.5%) ⬇️
message_ix_models/model/transport/build.py 94.1% <100.0%> (ø)
message_ix_models/model/transport/config.py 98.9% <ø> (ø)
message_ix_models/model/transport/data.py 98.9% <100.0%> (+<0.1%) ⬆️
message_ix_models/model/transport/groups.py 97.0% <100.0%> (ø)
message_ix_models/model/transport/report.py 60.0% <100.0%> (ø)
message_ix_models/model/transport/stock.py 100.0% <100.0%> (ø)
message_ix_models/tests/model/test_emissions.py 100.0% <100.0%> (ø)
...sage_ix_models/tests/model/transport/test_build.py 83.9% <ø> (ø)
message_ix_models/tests/test_tools.py 72.2% <100.0%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khaeru khaeru force-pushed the transport/2025-w39 branch 3 times, most recently from 27a9d6e to c02dd5d Compare October 27, 2025 21:19
@khaeru khaeru force-pushed the transport/2025-w39 branch from c02dd5d to 4f37479 Compare October 29, 2025 10:27
@khaeru khaeru force-pushed the transport/2025-w39 branch from 4f37479 to 8f08a5b Compare October 29, 2025 10:56
- Compute and transform bound_total_capacity_{lo,up} from stock-cap and
  population.
- Add to default build.
- Add .util._message_ix to support import from prior location.
- Update R12/pdt-cap/EDITS-CA.csv.
- Add R12/pdt-cap/EDITS-HA.csv.
@khaeru khaeru force-pushed the transport/2025-w39 branch from 8f08a5b to 27278b7 Compare October 29, 2025 11:44
@khaeru khaeru marked this pull request as ready for review October 29, 2025 15:10
@khaeru khaeru requested a review from r-aneeque as a code owner October 29, 2025 15:10
Copy link
Contributor

@r-aneeque r-aneeque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@khaeru
Copy link
Member Author

khaeru commented Oct 29, 2025

Some tests appear to be flaky due to network issues connecting to worldbank.org, e.g.:

ERROR message_ix_models/tests/tools/test_wb.py::test_get_income_group_codelist - requests.exceptions.ConnectionError: HTTPSConnectionPool(host='datacatalogfiles.worldbank.org', port=443): Max retries exceeded with url: /ddh-published/0037712/DR0090755/CLASS.xlsx (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f7d9b898190>: Failed to establish a new connection: [Errno 101] Network is unreachable'))

These could be resolved by:

  • Marking the tests as XFAIL and/or flaky. I think the latter may not help, since when the server is not responding, retries with pauses of a few seconds will not succeed after an initial failure.
  • Storing a mirror of the file in a more reliable location, e.g. on Zenodo or in this repo.

For now, I am repeatedly re-running jobs until they pass.

@khaeru khaeru merged commit aab0ba7 into main Oct 30, 2025
99 of 130 checks passed
@khaeru khaeru deleted the transport/2025-w39 branch October 30, 2025 09:16
@khaeru khaeru mentioned this pull request Nov 11, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants