Skip to content

Add option to keep controls expanded - #1605

Open
kohai-ut wants to merge 2 commits into
igrigorik:masterfrom
kohai-ut:feature/1604-keep-controls-expanded
Open

Add option to keep controls expanded#1605
kohai-ut wants to merge 2 commits into
igrigorik:masterfrom
kohai-ut:feature/1604-keep-controls-expanded

Conversation

@kohai-ut

@kohai-ut kohai-ut commented Aug 6, 2026

Copy link
Copy Markdown

Closes #1604.

What this solves

The controller normally reveals the rewind, speed, and advance buttons on hover, then collapses again after use or a timeout. This adds an option for users who want those controls to remain continuously available.

Behavior

  • Adds an unchecked Keep controls expanded preference: “Always show the rewind, speed, and advance buttons instead of revealing them only on hover.”
  • Keeps the controls expanded after interaction and idle time when enabled.
  • Applies preference changes immediately to controllers already open on the page; no reload is required.
  • Leaves the existing behavior unchanged by default and for profiles where the setting is absent.
  • Does not change the controller visibility toggle: the full controller can still be shown or hidden normally.
  • Saves and syncs the preference with the other settings.
  • Includes the preference in settings exports and restores it on import.

Validation

  • Unit suite: 536 tests passed.
  • Chrome display E2E: live preference changes, persistence after use/timeout, and restoration of hover behavior.
  • Existing display visibility matrix: 96/96 states passed.
  • Lint, formatting, build, and both TLC model checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add setting to keep controller expanded

1 participant