Skip to content

Model extension file access in Chrome E2E - #1586

Open
YUMA-NAGAO wants to merge 1 commit into
igrigorik:masterfrom
YUMA-NAGAO:codex/local-file-access-diagnostics
Open

Model extension file access in Chrome E2E#1586
YUMA-NAGAO wants to merge 1 commit into
igrigorik:masterfrom
YUMA-NAGAO:codex/local-file-access-diagnostics

Conversation

@YUMA-NAGAO

@YUMA-NAGAO YUMA-NAGAO commented Jul 10, 2026

Copy link
Copy Markdown

Summary

  • Keep the existing file-origin access flag used by the browser fixtures.
  • Add Chromium's extension-specific test switch so E2E runs model the user-enabled Allow access to file URLs setting.
  • Keep runtime code, manifest permissions, and product behavior unchanged.

Why

The E2E suite loads file:// fixtures, but --allow-file-access-from-files does not disable Chromium's separate user opt-in check for extensions injecting into file URLs. --disable-extensions-file-access-check is Chromium's test switch for that extension-specific permission path.

Chromium source: https://chromium.googlesource.com/chromium/src/+/main/chrome/common/chrome_switches.cc

Testing

  • npm ci
  • npm run lint
  • npm run build:release
  • npm test (43 files, 534 tests)
  • npm run test:e2e -- basic (10/10 passed)
  • Codex second-opinion review (no actionable findings)

GitHub Actions

The upstream CI run is awaiting repository-maintainer approval for a workflow from a fork. GitHub has not started any jobs yet: https://github.com/igrigorik/videospeed/actions/runs/30735334595

Notes

  • One file changed; no production code or manifest permissions changed.
  • Both flags are retained because they model separate file-origin and extension opt-in checks.

@YUMA-NAGAO
YUMA-NAGAO force-pushed the codex/local-file-access-diagnostics branch from f6cdb1b to 96cf1a6 Compare August 2, 2026 06:01
@YUMA-NAGAO YUMA-NAGAO changed the title Add local file access diagnostics and direct-file E2E coverage Model extension file access in Chrome E2E Aug 2, 2026
@YUMA-NAGAO
YUMA-NAGAO force-pushed the codex/local-file-access-diagnostics branch from 96cf1a6 to f9b5280 Compare August 2, 2026 06:07
@YUMA-NAGAO
YUMA-NAGAO marked this pull request as ready for review August 2, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant