Fix BloomFilter::Native#include? when multiple keys are passed#55
Open
rmm5t wants to merge 1 commit intoigrigorik:masterfrom
Open
Fix BloomFilter::Native#include? when multiple keys are passed#55rmm5t wants to merge 1 commit intoigrigorik:masterfrom
rmm5t wants to merge 1 commit intoigrigorik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the intended interface for
BloomFilter::Native#include?is to accept multiple keys and check if all are included in the filter set.However,
CBloomFilter#include?short-circuits after the first key.Closes #54
Note
I found this while forking this project into a smaller bloom_fit that is aimed at being just an in-memory Bloom filter with a small, Set-like API while using a better hash distribution for large sets. However, I want to make sure I'm backfilling any bugs or issues I find along the way