fix(pdf): Improve logging - #1338
Merged
Merged
Conversation
kesara
requested review from
holloway,
jennifer-richards,
rjsparks and
rudimatz
September 7, 2026 21:01
rudimatz
approved these changes
Sep 8, 2026
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
code change looks ok, but I can't confirm that the behavior it'll induce is "correct" :-)
Member
Author
IIRC Reason for having multiple logger entries was general logger entry didn't catch them all before. This issue seem to have corrected in fonttools package. |
holloway
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1337