Open
Conversation
jennifer-richards
requested changes
Apr 17, 2026
| self._sync_manager_role(user, claims) | ||
| return user | ||
|
|
||
| def _sync_manager_role(self, user, claims): |
Member
There was a problem hiding this comment.
Small refactor request: rather than teaching this module about how we manage permissions, give that responsibility to rpcauth.models.User. If it had a method like set_is_manager(value: bool) to do the work of creating/removing the can_hold_role entry, then backends.py stays independent of the rpc app.
I think that's mostly just moving code, not actually changing it.
jennifer-richards
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
give the manager role to RPC persons that hold the
chairrole for rpc in claim from DT