Skip to content

Fix also from em to controlling_em for all SystemParticipants #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

Fix also from em to controlling_em for all SystemParticipants #338

merged 3 commits into from
Aug 11, 2025

Conversation

danielfeismann
Copy link
Member

resolves #337

@danielfeismann danielfeismann added the bug Something isn't working label Jul 22, 2025
@danielfeismann danielfeismann self-assigned this Jul 22, 2025
@danielfeismann danielfeismann marked this pull request as ready for review July 22, 2025 16:40
@danielfeismann danielfeismann mentioned this pull request Aug 1, 2025
Open
staudtMarius
staudtMarius requested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already quiet good. I have just some small questions.

staudtMarius
staudtMarius approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staudtMarius staudtMarius merged commit 27c4f1b into main Aug 11, 2025
6 checks passed
@staudtMarius staudtMarius deleted the df/#337-controlling_em-sysParticipants branch August 11, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix from em to controlling_em for all SystemParticipants
2 participants
@danielfeismann @staudtMarius