-Check if data.zip already exists then skip download and continue extract file and Add support for Google Drive using gdown#55
Open
pokpong007 wants to merge 2 commits intoideasrule:masterfrom
Open
Conversation
- Introduced a `GDRIVE_CDN` flag to enable or disable Google Drive as the CDN. - Added a conditional import for `gdown` to avoid errors when `GDRIVE_CDN` is disabled. - Provided a fallback to the default CDN (`__data_url__`) when `GDRIVE_CDN` is off or `__gdrive__` is not configured. - Included error handling to alert users if `gdown` is required but not installed. - Ensured the script works seamlessly regardless of the availability of `gdown`.
- Introduced a `GDRIVE_CDN` flag to enable or disable Google Drive as the CDN. - Added a conditional import for `gdown` to avoid errors when `GDRIVE_CDN` is disabled. - Provided a fallback to the default CDN (`__data_url__`) when `GDRIVE_CDN` is off or `__gdrive__` is not configured. - Included error handling to alert users if `gdown` is required but not installed. - Ensured the script works seamlessly regardless of the availability of `gdown`.
pokpong007
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For people who already have the files and prefer not to re-download them from astro.uchicago.edu, we've added the option to use separate files. This is because the CDN can be slow in some countries due to its distance.
Introduced a
GDRIVE_CDNflag to enable or disable Google Drive as the CDN.Added a conditional import for
gdownto avoid errors whenGDRIVE_CDNis set to False.Provided a fallback to the default CDN (
__data_url__) whenGDRIVE_CDNis set to False or__gdrive__is not configured.Included error handling to alert users if
gdownis required but not installed.Check if data.zip already exists then skip download and continue extract file.