Skip to content

Conversation

@joshuahansel
Copy link
Contributor

Removed THM peacock plugins and shortened some THM tests.

@joshuahansel joshuahansel self-assigned this Dec 5, 2025
@joshuahansel joshuahansel marked this pull request as ready for review December 5, 2025 23:13
@moosebuild
Copy link
Contributor

moosebuild commented Dec 6, 2025

Job Documentation, step Docs: sync website on 79b7ed3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Test, step Results summary on 79b7ed3 wanted to post the following:

Framework test summary

Compared against 1189325 in job civet.inl.gov/job/3435065.

No change

Modules test summary

Compared against 1189325 in job civet.inl.gov/job/3435065.

Removed tests

Test Time (s)
thermal_hydraulics/test:components/inlet_mass_flow_rate_1phase.jacobian-water97 8.56
thermal_hydraulics/python/moose_thm:peacock/unit_converter.unit_conversion 0.68
thermal_hydraulics/python/moose_thm:peacock/unit_converter.plugin SKIP
thermal_hydraulics/python/moose_thm:peacock/model_builder.flow_channel_parameters_calculator SKIP
thermal_hydraulics/python/moose_thm:peacock/fluid_property_interrogator.fluid_property_interrogator SKIP

Added tests

Test Time (s)
thermal_hydraulics/test:components/inlet_mass_flow_rate_1phase.run_water97 3.07

Run time changes

Test Base (s) Head (s) +/-
thermal_hydraulics/test:problems/brayton_cycle.open 8.94 2.35 -73.70%

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 79b7ed3 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Thermal hydraulics

118932 #32049 79b7ed
Total Total +/- New
Rate 88.86% 88.96% +0.10% -
Hits 15480 15497 +17 0
Misses 1941 1924 -17 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@loganharbour loganharbour merged commit 4fde1b3 into idaholab:next Dec 10, 2025
69 checks passed
@loganharbour
Copy link
Member

lol @ budget in the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants