Skip to content

Conversation

@ke7kto
Copy link
Contributor

@ke7kto ke7kto commented Dec 2, 2025

Closes #32024

Reason

Improve backwards compatibility and enables testing of StochasticRunner.parallelWorker

Design

Add new test and edit type hint.

Impact

Improves python support

@moosebuild
Copy link
Contributor

Job Test, step Results summary on 57f017a wanted to post the following:

Framework test summary

Compared against 82bb60c in job civet.inl.gov/job/3419953.

No change

Modules test summary

Compared against 82bb60c in job civet.inl.gov/job/3419953.

No change

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 57f017a wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 57f017a wanted to post the following:

Framework coverage

82bb60 #32025 57f017
Total Total +/- New
Rate 85.99% 85.99% +0.00% -
Hits 125774 125775 +1 0
Misses 20500 20499 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@loganharbour loganharbour marked this pull request as ready for review December 9, 2025 18:11
@loganharbour loganharbour merged commit a9f5a13 into idaholab:next Dec 10, 2025
69 checks passed
@loganharbour
Copy link
Member

Sorry @ke7kto; didn't see the WIP at the end.

For future reference - you should open PRs as drafts (you can do this upon submission). This makes them explicitly not ready for review.

@ke7kto
Copy link
Contributor Author

ke7kto commented Dec 10, 2025

Sorry, thought I opened as a draft. There's no associated testing yet because I need to understand some things a bit better. Do you have some time tomorrow I might be able to ask some questions?

@loganharbour
Copy link
Member

Yep! I'm open most of the day and Zach's likely around too.

We just greatly expanded the unit testing for the moosecontrol (which this sits on), and are happy to support expansion of the rest of the utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StochasticControl.py syntax incompatible with python3.12

4 participants