Repository navigation
Thomas/fix feature volume vector postprocessor - #31990
Closed
Thomas-Ulrich wants to merge 1 commit into
Closed
Thomas-Ulrich wants to merge 1 commit into
Thomas-Ulrich wants to merge 1 commit into
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Contributor
|
@Thomas-Ulrich anybody at the US labs you work with we could ping for review? |
|
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #25035
(there is already this PR #25040, which has been stalled, and it seems I cannot reopen it).
Reason
to fix the issue identified.
Design
sum only over the quadrature points exceeding the threshold.
(TODO: double-check that compareValueWithThreshold returns the correct value with use_less_than_threshold_compariso=True).
Impact
no