-
Notifications
You must be signed in to change notification settings - Fork 1.2k
MFEM mumps solver #31989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFEM mumps solver #31989
Conversation
|
Job Precheck, step Versioner verify on dd642b0 wanted to post the following: Versioner templatesFound 14 templates, 0 failed Versioner influential filesFound 58 influential files, 1 changed, 0 added, 0 removed
Versioner versionsFound 9 packages, 1 changed, 1 failed
Verification failed. |
dd642b0 to
a40014f
Compare
nmnobre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Nice and short just as how I love it. :)
We're missing some docs in the form of MFEMMUMPS.md and perhaps an option to set the print level for consistency. I think we can postpone any other options to if/when we are pressed by any specific needs.
nmnobre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending a rebase, and assuming all tests pass, this is good to go.
55dfe03 to
2b38d01
Compare
|
Job Test, step Results summary on 2b38d01 wanted to post the following: Framework test summaryCompared against 701997c in job civet.inl.gov/job/3442489. No change Modules test summaryCompared against 701997c in job civet.inl.gov/job/3442489. No added testsRun time changes
|
|
Sorry for the pings, reviews got requested when I converted it from draft to ready to review. |
|
Job Documentation, step Docs: sync website on 2b38d01 wanted to post the following: View the site here This comment will be updated on new commits. |
|
I've successfully tested this on the |
|
Job Coverage, step Generate coverage on 2b38d01 wanted to post the following: Framework coverage
Modules coverageInconsistent report tags were found between the head and base reports. Inconsistent tags: Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Closes #31988
Requires #31906, I will rebase once that is merged.
Reason
Adds MUMPS solver
Impact
Only adds to API