Skip to content

Conversation

@Heinrich-BR
Copy link
Collaborator

Closes #31961

@Heinrich-BR Heinrich-BR marked this pull request as draft November 21, 2025 10:13
Heinrich-BR added a commit to Heinrich-BR/moose that referenced this pull request Nov 21, 2025
@Heinrich-BR Heinrich-BR force-pushed the HenriqueBR/complex_vars branch from 2e61001 to 690e929 Compare November 21, 2025 15:11
@moosebuild
Copy link
Contributor

moosebuild commented Nov 21, 2025

Job Documentation, step Docs: sync website on 027558d wanted to post the following:

View the site here

This comment will be updated on new commits.

@Heinrich-BR Heinrich-BR force-pushed the HenriqueBR/complex_vars branch 2 times, most recently from 116318b to 33246f4 Compare November 27, 2025 13:37
@Heinrich-BR Heinrich-BR marked this pull request as ready for review November 27, 2025 13:50
@moosebuild
Copy link
Contributor

moosebuild commented Nov 27, 2025

Job Coverage, step Generate coverage on 027558d wanted to post the following:

Framework coverage

6590aa #31962 027558
Total Total +/- New
Rate 85.99% 86.00% +0.01% 100.00%
Hits 125742 125983 +241 260
Misses 20494 20513 +19 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Member

@nmnobre nmnobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few tweaks.

@@ -0,0 +1,88 @@
//* This file is part of the MOOSE framework
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase and reimplement both the inner and external products in light of recent changes to their real counterparts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the rebase, but what part would you like to see reimplemented? I can see that the MFEMInnerProduct and the cross product have an MFEMScalarCoefficient as their scaling factor, whereas the complex versions have a constant complex number. However, I think it'd be best if we waited for the ComplexCoefficient to be merged into MFEM before trying to have a coefficient instead of a constant for the scaling.

@Heinrich-BR Heinrich-BR force-pushed the HenriqueBR/complex_vars branch from 0fb43ea to c7a8e79 Compare December 3, 2025 10:47
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on c7a8e79 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31962/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 6590aad929b47616320fcf1370ecbdd54f97310a

@Heinrich-BR Heinrich-BR force-pushed the HenriqueBR/complex_vars branch from c7a8e79 to ab378e0 Compare December 3, 2025 11:06
@moosebuild
Copy link
Contributor

Job Precheck, step Versioner verify on ab378e0 wanted to post the following:

Versioner templates

Found 14 templates, 0 failed

Versioner influential files

Found 58 influential files, 1 changed, 0 added, 0 removed

package status file
wasp CHANGE framework/contrib/wasp

Versioner versions

Found 9 packages, 2 changed, 2 failed

package status hash to hash version to version
wasp NEED BUMP 0320f16 f278c09 2025.09.19_02960f1 build 0 2025.09.19_02960f1 build 0
moose-dev NEED BUMP a20764f fc18d70 2025.11.24 2025.11.24

Verification failed.

@Heinrich-BR Heinrich-BR force-pushed the HenriqueBR/complex_vars branch from ab378e0 to 027558d Compare December 3, 2025 11:32
@moosebuild
Copy link
Contributor

Job Test, step Results summary on 027558d wanted to post the following:

Framework test summary

Compared against 6590aad in job civet.inl.gov/job/3425118.

No change

Modules test summary

Compared against 6590aad in job civet.inl.gov/job/3425118.

No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MFEM Complex AuxKernels

5 participants