-
Notifications
You must be signed in to change notification settings - Fork 1.2k
MFEM Complex AuxKernels #31962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
MFEM Complex AuxKernels #31962
Conversation
2e61001 to
690e929
Compare
|
Job Documentation, step Docs: sync website on 027558d wanted to post the following: View the site here This comment will be updated on new commits. |
116318b to
33246f4
Compare
|
Job Coverage, step Generate coverage on 027558d wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
87cd22f to
ed51973
Compare
nmnobre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few tweaks.
framework/doc/content/source/mfem/auxkernels/MFEMComplexCurlAux.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/mfem/auxkernels/MFEMComplexDivAux.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/mfem/auxkernels/MFEMHermitianInnerProductAux.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,88 @@ | |||
| //* This file is part of the MOOSE framework | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rebase and reimplement both the inner and external products in light of recent changes to their real counterparts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done the rebase, but what part would you like to see reimplemented? I can see that the MFEMInnerProduct and the cross product have an MFEMScalarCoefficient as their scaling factor, whereas the complex versions have a constant complex number. However, I think it'd be best if we waited for the ComplexCoefficient to be merged into MFEM before trying to have a coefficient instead of a constant for the scaling.
Added MFEMComplexVectorProjectionAux
Linting
Update sign on complex dot product
Fix complexScale
Add more complex auxkernel tests
0fb43ea to
c7a8e79
Compare
|
Job Precheck, step Clang format on c7a8e79 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
c7a8e79 to
ab378e0
Compare
|
Job Precheck, step Versioner verify on ab378e0 wanted to post the following: Versioner templatesFound 14 templates, 0 failed Versioner influential filesFound 58 influential files, 1 changed, 0 added, 0 removed
Versioner versionsFound 9 packages, 2 changed, 2 failed
Verification failed. |
ab378e0 to
027558d
Compare
|
Job Test, step Results summary on 027558d wanted to post the following: Framework test summaryCompared against 6590aad in job civet.inl.gov/job/3425118. No change Modules test summaryCompared against 6590aad in job civet.inl.gov/job/3425118. No change |
Closes #31961