Htc closures #31956

kyriv1980 · 2025-11-20T20:17:10Z

This Pr works on abstracting the heat transfer coefficient closure system. #30049 .

Additionally adds two more variations to the Dittus-Boelter model: Presser, Wiesman.

And the models referenced in #32029

modules/subchannel/doc/content/source/problems/QuadSubChannel1PhaseProblem.md

modules/subchannel/doc/content/source/problems/TriSubChannel1PhaseProblem.md

modules/subchannel/include/scmclosures/SCMHTCKazimiCarelli.h

modules/subchannel/src/scmclosures/SCMHTCDittusBoelter.C

modules/subchannel/src/scmclosures/SCMHTCGnielinski.C

modules/subchannel/src/scmclosures/SCMHTCKazimiCarelli.C

moosebuild · 2025-11-21T00:56:06Z

Job Documentation, step Docs: sync website on afdc1ec wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2025-11-22T00:58:19Z

Job Coverage, step Generate coverage on afdc1ec wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Subchannel

	701997	#31956 afdc1e
	Total	Total	+/-	New
Rate	94.01%	93.49%	-0.52%	100.00%
Hits	5948	6073	+125	253
Misses	379	423	+44	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

modules/subchannel/src/scmclosures/SCMHTCGnielinski.C

modules/subchannel/doc/content/source/problems/QuadSubChannel1PhaseProblem.md

modules/subchannel/doc/content/source/problems/TriSubChannel1PhaseProblem.md

modules/subchannel/src/scmclosures/SCMHTCDittusBoelter.C

modules/subchannel/src/scmclosures/SCMHTCGnielinski.C

modules/subchannel/src/scmclosures/SCMHTCKazimiCarelli.C

moosebuild · 2025-11-24T16:03:13Z

Job Precheck on b48d0b4 : invalidated by @kyriv1980

moosebuild · 2025-11-24T17:41:25Z

Job Precheck, step Clang format on a81a31d wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31956/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 5685ba093d40c41731669799c9692946167942b6

moosebuild · 2025-11-24T21:26:08Z

Job Framework 1 on cb3f48d : invalidated by @kyriv1980

moosebuild · 2025-11-25T15:50:16Z

Job Framework 1 on cb3f48d : invalidated by @kyriv1980

moosebuild · 2025-11-25T18:11:26Z

Job Coverage, step Verify coverage on cb3f48d wanted to post the following:

The following coverage requirement(s) failed:

Failed to generate framework coverage rate (required: 81.0%)

moosebuild · 2025-11-25T23:29:04Z

Job Coverage on cb3f48d : invalidated by @kyriv1980

moosebuild · 2025-11-25T23:35:57Z

Job Coverage, step Verify coverage on cb3f48d wanted to post the following:

The following coverage requirement(s) failed:

Failed to generate framework coverage rate (required: 81.0%)

moosebuild · 2025-12-02T21:36:23Z

Job Precheck on a50098c : invalidated by @kyriv1980

modules/subchannel/doc/content/source/scmclosures/SCMHTCGnielinski.md

modules/subchannel/doc/content/bib/subchannel.bib

modules/subchannel/doc/content/source/problems/QuadSubChannel1PhaseProblem.md

modules/subchannel/doc/content/source/problems/TriSubChannel1PhaseProblem.md

modules/subchannel/doc/content/source/scmclosures/SCMHTCClosureBase.md

modules/subchannel/doc/content/source/scmclosures/SCMHTCDittusBoelter.md

modules/subchannel/src/scmclosures/SCMHTCClosureBase.C

modules/subchannel/doc/content/source/scmclosures/SCMHTCClosureBase.md

moosebuild · 2025-12-10T19:44:39Z

Job Test, step Results summary on afdc1ec wanted to post the following:

Framework test summary

Compared against 701997c in job civet.inl.gov/job/3442489.

No change

Modules test summary

Compared against 701997c in job civet.inl.gov/job/3442489.

Added tests

Test	Time (s)
`subchannel/test:problems/heat_transfer_correlations.EBR-II_SHRT-17_SS/dittus_boelter_Weisman`	4.03
`subchannel/test:problems/heat_transfer_correlations.EBR-II_SHRT-17_SS/borishanskii`	3.76
`subchannel/test:problems/heat_transfer_correlations.EBR-II_SHRT-17_SS/schad_modified`	3.73
`subchannel/test:problems/heat_transfer_correlations.EBR-II_SHRT-17_SS/graber_rieger`	3.67
`subchannel/test:problems/heat_transfer_correlations.EBR-II_SHRT-17_SS/dittus_boelter_Presser`	3.65

Run time changes

Test	Base (s)	Head (s)	+/-
`stochastic_tools/test:web_server_control.stochastic_control/batch_reset`	299.98	3.09	-98.97%

moosebuild · 2025-12-10T23:33:49Z

Job HPC on afdc1ec : invalidated by @kyriv1980

luizaldeia · 2025-12-15T18:45:50Z

modules/subchannel/doc/content/source/problems/TriSubChannel1PhaseProblem.md

 - $T_{bulk,d}(z)$ is the bulk temperature of the subchannel next to the duct node $d$
 - $q''_d(z)$ is the heat flux at the duct at a height $z$
- $h_d(z)$ is the heat exchange coefficient for the subchannel next to the duct node at a height $z$
+- $h_d(z)$ is the convective heat transfer coefficientfor the subchannel next to the duct node at a height $z$


Small typo here: coefficientfor instead of coefficient for

luizaldeia · 2025-12-15T19:05:49Z

modules/subchannel/src/scmclosures/SCMHTCBorishanskii.C

+  {
+    NuT += corr_prefactor * std::pow(Pe - 200.0, 0.9);
+  }
+  else if (Pe < 200.0)


The Borishanskii correlation has an option for the case where Pe<=200:

kyriv1980 force-pushed the HTC_closures branch 3 times, most recently from 0ef0fbd to ccb9e0e Compare November 20, 2025 21:01

GiudGiud self-assigned this Nov 20, 2025

GiudGiud requested changes Nov 21, 2025

View reviewed changes

kyriv1980 force-pushed the HTC_closures branch 3 times, most recently from 7c5466b to 681a68f Compare November 21, 2025 20:16

kyriv1980 requested a review from GiudGiud November 21, 2025 20:17

kyriv1980 force-pushed the HTC_closures branch from 681a68f to f2cf291 Compare November 21, 2025 20:24

GiudGiud requested changes Nov 22, 2025

View reviewed changes

kyriv1980 force-pushed the HTC_closures branch 3 times, most recently from 52f3993 to b48d0b4 Compare November 24, 2025 15:56

kyriv1980 force-pushed the HTC_closures branch from b48d0b4 to 68e64b7 Compare November 24, 2025 16:06

kyriv1980 force-pushed the HTC_closures branch from 68e64b7 to cb3f48d Compare November 24, 2025 18:32

kyriv1980 requested a review from GiudGiud November 25, 2025 19:59

kyriv1980 added 4 commits November 25, 2025 16:50

create base class for HTCs Refs idaholab#30049

ac2d519

create Dittus Boelter HTC idaholab#30049

53a09fc

implement Dittus Boelter HTC idaholab#30049

39b7803

rename HTC idaholab#30049

4a0b220

kyriv1980 requested a review from GiudGiud December 2, 2025 20:18

kyriv1980 force-pushed the HTC_closures branch 2 times, most recently from c0b4448 to a50098c Compare December 2, 2025 21:24

luizaldeia reviewed Dec 3, 2025

View reviewed changes

clarify laminar Nusselt number and regold idaholab#30049

f83c59a

kyriv1980 force-pushed the HTC_closures branch 2 times, most recently from dc00aae to df9a859 Compare December 3, 2025 16:57

address reviewer comments 2 idaholab#30049

4498c97

kyriv1980 force-pushed the HTC_closures branch from df9a859 to 4498c97 Compare December 3, 2025 17:07

kyriv1980 requested a review from luizaldeia December 3, 2025 19:19

add dittus-boelter correction factors idaholab#30049

1623e21

kyriv1980 force-pushed the HTC_closures branch 2 times, most recently from 1c6ac65 to afc6fd6 Compare December 3, 2025 20:07

kyriv1980 mentioned this pull request Dec 3, 2025

Adding new heat transfer closures into MOOSE-SCM #32029

Open

kyriv1980 force-pushed the HTC_closures branch from afc6fd6 to 32a560f Compare December 3, 2025 21:18

address reviewer comments 3 idaholab#30049

03826c3

kyriv1980 force-pushed the HTC_closures branch from 32a560f to 03826c3 Compare December 4, 2025 19:55

luizaldeia approved these changes Dec 8, 2025

View reviewed changes

kyriv1980 added 2 commits December 9, 2025 14:41

add more correlations idaholab#32029

0b82236

create new tests idaholab#32029

64b980a

kyriv1980 requested a review from luizaldeia December 9, 2025 23:05

kyriv1980 force-pushed the HTC_closures branch 3 times, most recently from 37602fc to 3ba55de Compare December 9, 2025 23:32

create new docs idaholab#32029

afdc1ec

kyriv1980 force-pushed the HTC_closures branch from 3ba55de to afdc1ec Compare December 10, 2025 18:33

luizaldeia reviewed Dec 15, 2025

View reviewed changes

Htc closures #31956

Are you sure you want to change the base?

Htc closures #31956

Conversation

kyriv1980 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Framework coverage

Modules coverage

Subchannel

Full coverage reports

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Nov 24, 2025

Uh oh!

moosebuild commented Nov 24, 2025

Uh oh!

moosebuild commented Nov 24, 2025

Uh oh!

moosebuild commented Nov 25, 2025

Uh oh!

moosebuild commented Nov 25, 2025

Uh oh!

moosebuild commented Nov 25, 2025

Uh oh!

moosebuild commented Nov 25, 2025

Uh oh!

moosebuild commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Dec 10, 2025

Framework test summary

Modules test summary

Added tests

Run time changes

Uh oh!

moosebuild commented Dec 10, 2025

Uh oh!

luizaldeia Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

luizaldeia Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

kyriv1980 commented Nov 20, 2025 •

edited

Loading

moosebuild commented Nov 21, 2025 •

edited

Loading

moosebuild commented Nov 22, 2025 •

edited

Loading