Testing Suite

package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "test": "npm run lint && npm run tests",
     "lint": "eslint src *.js",
-    "tests": "node test/index.js",
+    "tests": "mocha \"test/**/*.js\"",
     "webpack": "./node_modules/.bin/webpack --config webpack.config.js",
     "docs": "./node_modules/.bin/jsdoc src src/matches src/playerseason README.md -t ./node_modules/minami && echo pubg.js.org > ./out/CNAME"
   },
@@ -30,9 +30,11 @@
     "snekfetch": "^4.0.0"
   },
   "devDependencies": {
+    "chai": "^4.1.2",
     "eslint": "^4.19.1",
     "jsdoc": "^3.5.5",
     "minami": "^1.2.3",
+    "mocha": "^5.1.1",
     "uglifyjs-webpack-plugin": "^1.2.5",
     "webpack": "^3.11.0"
   }

src/Client.js

@@ -1,7 +1,9 @@
 const snekfetch = require('snekfetch');
 const Package = require('../package.json');
 
+const Constants = require('./util/Constants');
 const Util = require('./util/Util');
+const Errors = require('./util/Errors');
 const Player = require('./Player');
 const Match = require('./matches/Match');
 const Status = require('./Status');
@@ -14,9 +16,13 @@ const PlayerSeason = require('./playerseason/PlayerSeason');
  * @param {string} [defaultShard='pc-oc'] Default shard to use if none provided in methods
  */
 class Client {
-    constructor(key, defaultShard = 'pc-oc') {
+    constructor(key, defaultShard = Constants.DEFAULT_SHARD) {
         if (!key) {
-            throw new Error('No API key passed.');
+            throw new Error(Errors.NO_API_KEY);
+        } else if (typeof key !== 'string') {
+            throw new Error(Errors.INVALID_API_KEY);
+        } else if (!Util.verifyShard(defaultShard)) {
+            throw new Error(Errors.NON_EXISTENT_SHARD_ID);
         }
 
         /**

src/util/Constants.js

@@ -1,6 +1,8 @@
 module.exports = {
     BASE_URL: 'https://api.playbattlegrounds.com',
 
+    DEFAULT_SHARD: 'pc-oc',
+
     SHARDS: [
         'xbox-as',
         'xbox-eu',

src/util/Errors.js

@@ -0,0 +1,8 @@
+module.exports = {
+    NO_API_KEY: 'No API key provided',
+
+    INVALID_SHARD_ID: 'Invalid shard/region ID provided',
+    INVALID_API_KEY: 'Invalid API key provided',
+
+    NON_EXISTENT_SHARD_ID: 'Shard/region ID provided does not exist',
+};

test/Client/test.js

@@ -0,0 +1,40 @@
+const expect = require('chai').expect
+
+const pubg = require('../../')
+const Errors = require('../../src/util/Errors')
+const Constants = require('../../src/util/Constants')
+
+const Client = pubg.Client
+
+describe('Client', function() {
+	it('should throw an error when an API key is not passed to it', function() {
+		expect(function() {
+			client = new Client()
+		}).to.throw(Error).with.property('message', Errors.NO_API_KEY)
+	})
+
+	it('should throw an error when a non-string is passed as an API key', function() {
+		expect(function() {
+			client = new Client(123)
+		}).to.throw(Error).with.property('message', Errors.INVALID_API_KEY)
+	})
+
+	it('should throw an error if an invalid region is passed to it', function() {
+		expect(function() {
+			client = new Client('non-existent-key', 'france')
+		}).to.throw(Error).with.property('message', Errors.NON_EXISTENT_SHARD_ID)
+	})
+
+	it('should store the API key and shard correctly', function() {
+		ApiKey = 'non-existent-key'
+		region = 'pc-na'
+		client = new Client(ApiKey, region)
+		expect(client).to.have.property('key').that.equals(ApiKey)
+		expect(client).to.have.property('defaultShard').that.equals(region)
+	})
+
+	it('should set a defaultShard if one is not specified', function() {
+		client = new Client('non-existent-key')
+		expect(client).to.have.property('defaultShard', Constants.DEFAULT_SHARD)
+	})
+})