[Sprint 22 / PD-401] [Enhancement] Update Github Workflows #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threeal
requested changes
Feb 28, 2024
…kflows, and remove workflow run
threeal
approved these changes
Mar 9, 2024
Member
threeal
left a comment
threeal
left a comment
There was a problem hiding this comment.
All looks good in this PR, but it would be better if you could also remove the other unused workflow.
Regarding the failed workflow run, it seems that it was caused by a failed build in the Kansei package (see this for details). I suggest fixing that issue first before continuing to update the workflow in this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/jira/software/c/projects/PD/boards/4?selectedIssue=PD-401
Description
update github workflow using ros2-ws-action
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)