Add tests for Ice constants and default values#4373
Merged
bernardnormier merged 2 commits intoicerpc:mainfrom Apr 6, 2026
Merged
Add tests for Ice constants and default values#4373bernardnormier merged 2 commits intoicerpc:mainfrom
bernardnormier merged 2 commits intoicerpc:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new generator baseline tests to validate Slice/Ice constant emission and default value initialization behaviors in the generated C# code.
Changes:
- Introduces a new
ConstTestsSlice file + NUnit test suite to validate primitive, string (escape sequences), and enum constants (including aliases). - Introduces a new
DefaultValueTestsSlice file + NUnit test suite to validate default values for structs, classes, and exceptions (including defaults sourced from constants). - Covers qualification variations for enums/constants (
::Fully::Qualified, module-qualified, and unqualified).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/IceRpc.Ice.Generator.Base.Tests/ConstTests.ice | Defines enums + constants (including aliases) used to validate constant mapping. |
| tests/IceRpc.Ice.Generator.Base.Tests/ConstTests.cs | NUnit tests verifying generated constant values and escape sequence preservation. |
| tests/IceRpc.Ice.Generator.Base.Tests/DefaultValueTests.ice | Defines structs/classes/exceptions with explicit defaults (literal and const-based). |
| tests/IceRpc.Ice.Generator.Base.Tests/DefaultValueTests.cs | NUnit tests asserting generated default-value initialization semantics. |
pepone
approved these changes
Apr 6, 2026
externl
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on zeroc-ice/ice#5282