Skip to content

icat.lucene support for InvestigationSample#390

Open
patrick-austin wants to merge 1 commit intoschema-investigationsamplefrom
investigationsample_lucene_support
Open

icat.lucene support for InvestigationSample#390
patrick-austin wants to merge 1 commit intoschema-investigationsamplefrom
investigationsample_lucene_support

Conversation

@patrick-austin
Copy link
Contributor

Supports the new InvestigationSample entity and the removal of the direct Investigation<->Sample relationship for icat.lucene. Note this is dependent on icatproject/icat.lucene#75 and icatproject-contrib/icat-ansible#123

  • Change ansible branch to one which (will) install the latest version of lucene, required for the InvestigationSample to be indexed in place of Sample.
  • Re-introduces the Investigation->Sample mapping when indexing documents with the additional step of InvestigationSample
  • Remove "sample.investigation.id" field, as it is no longer relevant/required (Investigation id does not directly appear on Sample anymore).
  • Replace references to the Sample index with InvestigationSample.
  • Add special case to handle the pluralisation of Investigation.samples (rather than Investigation.investigationSamples) when faceting
  • Re-enable previously failing tests.

@patrick-austin patrick-austin marked this pull request as ready for review March 4, 2026 15:52
@patrick-austin patrick-austin requested a review from RKrahl March 4, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant