Modernize PointOfFocus for production deployment - #3
Merged
Conversation
Refactor the service into a testable app factory with typed errors, resource limits, and correct HTTP status codes. Upgrade Flask, OpenCV, and NumPy; fix Docker with gunicorn, health checks, and a non-root user. Add pytest coverage, ruff linting, and GitHub Actions CI. Extend /focus with algorithm selection, center bias, saliency score, crop box, and multipart uploads while keeping the core JSON contract stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/focuswith algorithm selection, configurable center bias, saliency score, optional crop box, and multipart uploads while keeping the core JSON contract stable.Test plan
GET /healthreturns 200GET /focus?path=<local-image>returns focus + dimensionsGET /focus?url=<image-url>works for internal image URLsPOST /focuswith multipartfilereturns 200docker build -t saliency-focus . && docker run --rm -p 5000:5000 saliency-focus