scrape/new-rules-2026-06-11: 6 new sources#11
Conversation
📝 WalkthroughWalkthroughThis PR introduces three new rule configuration files for a password and pattern generation system. Two foundational utility rules—one enumerating all two-digit digit combinations and another defining year-generation patterns—support a comprehensive 1227-line password-mutation rule containing case transformations, numeric suffix variants, date-like patterns, leetspeak substitutions, and word-doubling directives. ChangesNew Rule Definitions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
mgolding1/two_digits_end.rule (1)
1-100: Normalize CRLF/trailing whitespace inmgolding1/two_digits_end.rule
$d $dformatting is consistent with other.rulefiles in this repo and with Hashcat’s whitespace-as-separator behavior, so the$0 $1-style entries shouldn’t require conversion to$0$1for correctness. The main cleanup opportunity is that this file uses CRLF (\r\n) and has trailing spaces before\r(e.g., line 1); switch to LF and trim end-of-line whitespace to avoid tooling/portability issues.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@mgolding1/two_digits_end.rule` around lines 1 - 100, The file mgolding1/two_digits_end.rule contains CRLF line endings and trailing spaces (e.g., lines with "$0 $1 " have a trailing space before CR), so convert the file to use LF line endings and remove all end-of-line whitespace while keeping the existing "$0 $0", "$0 $1", ... "$9 $9" token spacing intact (do not collapse the space between tokens); update the file encoding/commit so tooling sees normalized LF endings and no trailing spaces.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ap0stl3/BestTexas.rule`:
- Around line 1161-1193: The rule block contains many exact duplicate L33T
directive lines (e.g., "ss$sS$sa@sA@sl1sL1se3sE3so0sO0",
"ss$sS$sa@sA@sl!sL!se3sE3so0sO0", "ss$sS$sa@sA@so0sO0si1sI1", and others) which
should be deduplicated; locate the repeated directive strings in this chunk and
remove duplicate occurrences so each unique directive appears only once
(preserve one canonical instance and the original ordering where possible) to
avoid redundant candidate generation and reduce compute cost.
- Around line 35-36: The second occurrence of the token pair "$5 $%" is a
duplicate; replace that duplicate with the reverse pair "$% $5" so the mutation
pair block remains bidirectional (ensure the pair "$5 $%" and its reverse "$%
$5" both appear, replacing the repeated "$5 $%" line).
---
Nitpick comments:
In `@mgolding1/two_digits_end.rule`:
- Around line 1-100: The file mgolding1/two_digits_end.rule contains CRLF line
endings and trailing spaces (e.g., lines with "$0 $1 " have a trailing space
before CR), so convert the file to use LF line endings and remove all
end-of-line whitespace while keeping the existing "$0 $0", "$0 $1", ... "$9 $9"
token spacing intact (do not collapse the space between tokens); update the file
encoding/commit so tooling sees normalized LF endings and no trailing spaces.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0c7a91df-9bbb-427c-99b9-f28102386b70
📒 Files selected for processing (12)
alexeypetrenko/years.ruleap0stl3/BestTexas.ruleap0stl3/TexasBig.rulee-fensive/efensive.ruleevilmog/auto.ruleevilmog/evil.ruleevilmog/generated2-full.ruleevilmog/generated3.ruleevilmog/new-auto.ruleevilmog/omgwtfbbq.optimized.rulemgolding1/two_digits_end.rulesparcflow/corporate.rule
| $5 $% | ||
| $5 $% |
There was a problem hiding this comment.
Replace duplicated $5 $% with missing reverse pair.
Line 36 repeats Line 35, so the reverse mutation ($% $5) is missing while other pairs in this block are bidirectional.
Proposed fix
$5 $%
-$5 $%
+$% $5📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| $5 $% | |
| $5 $% | |
| $5 $% | |
| $% $5 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ap0stl3/BestTexas.rule` around lines 35 - 36, The second occurrence of the
token pair "$5 $%" is a duplicate; replace that duplicate with the reverse pair
"$% $5" so the mutation pair block remains bidirectional (ensure the pair "$5
$%" and its reverse "$% $5" both appear, replacing the repeated "$5 $%" line).
| ss$sS$sa@sA@sl1sL1se3sE3so0sO0 | ||
| ss$sS$sa@sA@sl!sL!se3sE3so0sO0 | ||
| ss$sS$sa@sA@sl1sL1se3sE3so0sO0 | ||
| ss$sS$sa@sA@sl!sL!se3sE3si1sI1 | ||
| ss$sS$sa@sA@sl!sL!se3sE3 | ||
| ss$sS$sa@sA@sl1sL1se3sE3 | ||
| ss$sS$sa@sA@sl!sL!so0sO0si1sI1 | ||
| ss$sS$sa@sA@sl!sL!so0sO0 | ||
| ss$sS$sa@sA@sl1sL1so0sO0 | ||
| ss$sS$sa@sA@sl!sL!so0sO0si1sI1 | ||
| ss$sS$sa@sA@sl!sL!so0sO0 | ||
| ss$sS$sa@sA@sl1sL1so0sO0 | ||
| ss$sS$sa@sA@se3sE3so0sO0si1sI1 | ||
| ss$sS$sa@sA@se3sE3so0sO0 | ||
| ss$sS$sl!sL!se3sE3so0sO0si1sI1 | ||
| ss$sS$sl!sL!se3sE3so0sO0 | ||
| ss$sS$sl1sL1se3sE3so0sO0 | ||
| sa@sA@sl!sL!se3sE3so0sO0si1sI1 | ||
| sa@sA@sl!sL!se3sE3so0sO0 | ||
| sa@sA@sl1sL1se3sE3so0sO0 | ||
| ss$sS$sa@sA@so0sO0si1sI1 | ||
| ss$sS$sa@sA@so0sO0 | ||
| sl!sL!se3sE3so0sO0si1sI1 | ||
| sl!sL!se3sE3so0sO0 | ||
| sl1sL1se3sE3so0sO0 | ||
| sa@sA@sl!sL!se3sE3si1sI1 | ||
| sa@sA@sl!sL!se3sE3 | ||
| sa@sA@sl1sL1se3sE3 | ||
| ss$sS$sa@sA@so0sO0si1sI1 | ||
| ss$sS$sa@sA@so0sO0 | ||
| sa@sA@sl!sL!se3sE3si1sI1 | ||
| sa@sA@sl!sL!se3sE3 | ||
| sa@sA@sl1sL1se3sE3 |
There was a problem hiding this comment.
Deduplicate repeated L33T directives to avoid redundant candidate generation.
This block has several exact duplicate rules (e.g., Lines 1161/1163, 1168/1171, 1181/1189, 1182/1190, 1186/1191, 1187/1192, 1188/1193). These duplicates add compute cost without expanding mutation coverage.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ap0stl3/BestTexas.rule` around lines 1161 - 1193, The rule block contains
many exact duplicate L33T directive lines (e.g.,
"ss$sS$sa@sA@sl1sL1se3sE3so0sO0", "ss$sS$sa@sA@sl!sL!se3sE3so0sO0",
"ss$sS$sa@sA@so0sO0si1sI1", and others) which should be deduplicated; locate the
repeated directive strings in this chunk and remove duplicate occurrences so
each unique directive appears only once (preserve one canonical instance and the
original ordering where possible) to avoid redundant candidate generation and
reduce compute cost.
1 participant
New Sources
E-Fensive/hashcatrules(efensive.rule, 250k lines)n0kovo/hashcat-rules-collection/evilmog(6 files: auto, evil, generated2-full, generated3, new-auto, omgwtfbbq.optimized)sparcflow/HackLikeALegend(corporate.rule, 4.5k lines)Ap0stl3-git/hashcat-rules(BestTexas.rule 1.2k lines, TexasBig.rule 795k lines)mgolding1/rules(two_digits_end.rule, 100 lines)alexeypetrenko/hashcat-rules(years.rule, 20 lines)Stats
6 new folders, 11 new rule files added.
Automated scrape run: 2026-06-11
Summary by CodeRabbit