Rust bindings for qclib #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| [workspace.package] | ||
| edition = "2021" | ||
| license-file = "LICENSE" | ||
|
|
||
| [package] | ||
| name = "qclib" | ||
| version = "2.0.0" | ||
|
There was a problem hiding this comment. What's the significance of "version"? Should this reflect the actual package's version? There was a problem hiding this comment. This is the version of the rust crate (library). I had it aligned with the version of the C library, but this will get awkward if we have changes in the crate and release a new version while the C library has not changed. I commented here before changing it. I'm open to suggestions since I'm not sure what the best handling is. |
||
| edition.workspace = true | ||
| license-file.workspace = true | ||
| description = "Rust bindings for qclib (Query Capacity Library)" | ||
|
|
||
| [dependencies] | ||
| serde_json = { version = "1.0", optional = true } | ||
|
|
||
| [features] | ||
| all = ["json"] | ||
| json = ["dep:serde_json"] | ||
|
|
||
| [dependencies.sys] | ||
| package = "qclib-sys" | ||
| path = "qclib-sys" | ||
| version = "2" | ||
|
|
||
| [dev-dependencies] | ||
| clap = { version = "4.5", features = ["derive"] } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../LICENSE | ||
|
There was a problem hiding this comment. Use a symlink instead? I assume Rust strictly requires a license file..? There was a problem hiding this comment. It is one :) Yes, to publish the crate Rust requires an explicit license. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the year of the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's the Rust edition (think C standard revisions like C89, C11 and so on) used for this crate.