Skip to content

Conversation

@alongosz
Copy link
Member

@alongosz alongosz commented Nov 20, 2024

Caution

This is a part of bigger set of changes, to be merged together when ready

  • Remove TMP commits before merge
🎫 Issue IBX-8470

Related PRs:

Description:

This PR bumps Symfony to v6 with necessary codebase upgrades.

Please take a look at RestAuthenticator changes. getPassword method is completely gone from UserInterface, without any replacement, so not sure what will be end result of that change. Temporarily placed empty string there.

I'll need to go back to REST Functional tests once full-stack app is upgraded.

Key changes:

  • [Composer] Dropped obsolete ci-scripts from dev requirements
  • Bumped Symfony packages requirements to ^6.4
  • Dropped Symfony Container dependency from REST base controller
  • Dropped Symfony Container dependency from Content controller
  • [Security] Aligned RestAuthenticator with Symfony 6
  • Improved Controllers code quality
  • Aligned SessionController with Symfony 6
  • [PHPStan] Removed resolved issues from the baseline
  • [Tests] Aligned VisitorTest with Symfony 6

QA:

Sanities in the form of regression tests.

Documentation:

No documentation required.

@alongosz alongosz marked this pull request as ready for review November 20, 2024 13:36
@sonarqubecloud
Copy link

@ViniTou ViniTou force-pushed the ibx-8470-symfony-6 branch from b05c4b4 to 7f1c740 Compare January 30, 2025 13:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

@adamwojs adamwojs merged commit d87f621 into main Feb 4, 2025
9 of 10 checks passed
@adamwojs adamwojs deleted the ibx-8470-symfony-6 branch February 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants