Skip to content

Conversation

@alongosz
Copy link
Member

@alongosz alongosz commented Mar 25, 2024

🎫 Issue IBX-7785

Related PRs:

  • ibexa/personalization#327
  • ibexa/dashboard#114
  • ibexa/product-catalog#1143

Description:

Seems in some cases, like an upgrade from 4.5.6 to 4.6.2 (executed on the installed version from the tag, not x-dev), since Gregwar\CaptchaBundle in not explicitly listed in our bundles manifest, its placement in the bundles list is arbitrary (I'm guessing from some generic Symfony bundles recipe). It needs to be placed after Twig Bundle, because it relies directly on a parameter declared by Twig extension.

$ php bin/console cache:clear

In ParameterBag.php line 93:
                                                                      
  You have requested a non-existent parameter "twig.form.resources".

We require anyway that bundle in the Product, so maybe there's nothing wrong with declaring it explicitly?

$ composer why gregwar/captcha-bundle
ibexa/form-builder v4.6.2 requires  gregwar/captcha-bundle (^2.1)  
ibexa/headless     v4.6.2 requires  gregwar/captcha-bundle (^2.1)

TODO

  • See if this actually works // seems there's no change in recipes

@github-actions
Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-113

before executing the recipes.

@alongosz alongosz changed the title [ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundl… [ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundles list Mar 25, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs
Copy link
Member

adamwojs commented Feb 2, 2025

@alongosz Rebase is needed here

@alongosz alongosz force-pushed the ibx-7785-gregwar-bundle-after-twig branch from 390c818 to 21647a2 Compare February 3, 2025 14:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

@alongosz
Copy link
Member Author

alongosz commented Feb 3, 2025

@adamwojs rebased, however the issue at hand has been postponed. Does this mean that I'm supposed to be working on this next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants