Skip to content

Conversation

@Sztig
Copy link
Contributor

@Sztig Sztig commented Oct 2, 2025

🎫 Issue IBX-10705

Related PRs:

Description:

As mentioned in the public ticket itself, Varnish fails to cache any content in dev env because the application sends profiler-related Set-Cookie headers, this change was introduced in 7.3 in security-bundle package.
I've updated VCL files to bring varnish and symfonys profiler back to working order.
The fix is up to debate, during the tests with @reithor and @vidarl we didn't discover any breaking issue.

@vidarl
Copy link
Contributor

vidarl commented Oct 2, 2025

I think it should also be fixed for Fastly : https://github.com/ibexa/fastly/blob/main/fastly/ibexa_main.vcl#L83

@Sztig
Copy link
Contributor Author

Sztig commented Oct 2, 2025

I think it should also be fixed for Fastly : https://github.com/ibexa/fastly/blob/main/fastly/ibexa_main.vcl#L83

I will create another PR, thanks for letting me know

@Sztig Sztig force-pushed the IBX-10705-v5-varnish-profiler-fix branch from 688a7cc to 2580a70 Compare October 8, 2025 10:06
@Steveb-p
Copy link
Contributor

Steveb-p commented Nov 5, 2025

May I ask how exactly this fix helps with profiler related cookies?

I assume it works because cookie created for profiler is {$firewallName}_auth_profile_token and {$firewallName}_deauth_profile_token, and this would match ibexa_auth_profile_token?

Isn't the rule too broad? In the current setup it will match anything that looks like ibexa_* or ibexa-*.

@Sztig
Copy link
Contributor Author

Sztig commented Nov 13, 2025

@Steveb-p you are correct about matching, you can see the actual implementation here symfony/security-bundle@f0b504e
About the broadness of the rule, I'm not sure, during the tests this didn't rise any issues.

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on DXP 5.0 ddev/varnish.

@konradoboza konradoboza merged commit 2c22c56 into main Nov 21, 2025
7 checks passed
@konradoboza konradoboza deleted the IBX-10705-v5-varnish-profiler-fix branch November 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants