-
Notifications
You must be signed in to change notification settings - Fork 5
IBX-10705: Updated vcl to fix caching in dev env and re-enable symfony profiler #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it should also be fixed for Fastly : https://github.com/ibexa/fastly/blob/main/fastly/ibexa_main.vcl#L83 |
I will create another PR, thanks for letting me know |
688a7cc to
2580a70
Compare
|
May I ask how exactly this fix helps with profiler related cookies? I assume it works because cookie created for profiler is Isn't the rule too broad? In the current setup it will match anything that looks like |
|
@Steveb-p you are correct about matching, you can see the actual implementation here symfony/security-bundle@f0b504e |
tomaszszopinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on DXP 5.0 ddev/varnish.
Related PRs:
Description:
As mentioned in the public ticket itself, Varnish fails to cache any content in
devenv because the application sends profiler-related Set-Cookie headers, this change was introduced in 7.3 insecurity-bundlepackage.I've updated VCL files to bring varnish and symfonys profiler back to working order.
The fix is up to debate, during the tests with @reithor and @vidarl we didn't discover any breaking issue.