IBX-8470: Upgraded codebase to Symfony 6 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
konradoboza
approved these changes
Nov 28, 2024
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
However, switching to constructor property promotion within similar small PRs is pretty easy, so I would do this. Unless, there is plan to "Rectorize" all the codebase or perform any automatic voodoo to make it happen.
| use Twig\Profiler\Profile; | ||
|
|
||
| class TwigDataCollector extends BaseCollector implements LateDataCollectorInterface | ||
| class TwigDataCollector extends BaseCollector |
There was a problem hiding this comment.
Suggested change
| class TwigDataCollector extends BaseCollector | |
| final class TwigDataCollector extends BaseCollector |
Comment on lines
27
to
29
| /** | ||
| * @var \Ibexa\DesignEngine\Templating\TemplatePathRegistryInterface | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var \Ibexa\DesignEngine\Templating\TemplatePathRegistryInterface | |
| */ |
20 tasks
adamwojs
force-pushed
the
ibx-8470-symfony-6
branch
from
3d0eed8 to
8543350
Compare
|
adamwojs
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a part of bigger set of changes, to be merged together when ready
Related PRs:
Description:
This PR bumps Symfony to v6 with codebase upgrades.
Key changes:
tests/bundledirectoryQA:
Sanities in the form of regression tests.
Documentation:
No documentation required.