Fixed issues related to twig/twig 3.15 in tests #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Nov 19, 2024
alongosz
approved these changes
Nov 19, 2024
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
Wouldn't it be better to have our own base class for extensions then? Not a huge fan of traits, especially the ones used in the object of the same base.
+1, given this is a quick fix for failing CI
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Show resolved
Hide resolved
Contributor
Author
I've considered making this an abstract. My argument against is that this is a particular behavior that will be gone with 5.0. By making it a trait, it will be more easily removed. Without touching the extension tree. |
konradoboza
approved these changes
Nov 19, 2024
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Show resolved
Hide resolved
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Outdated
Show resolved
Hide resolved
|
Contributor
Author
|
Merged up into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes issues related to recent
twig/twig3.15 release, which changes how deprecation information should be passed into Twig Extensions.To maintain compatibility with earlier Twig versions (most recent PHP 7.4 compatible version of Twig is 3.11) a specific class check is used.
Due to small differences in Twig output, snapshots of results for Twig templating is split between 8.0/7.4 versions where applicable.
For QA:
Documentation: